Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK] Remove unused member variables from SyncMetricStorage #2294

Merged
merged 2 commits into from
Sep 3, 2023
Merged

[SDK] Remove unused member variables from SyncMetricStorage #2294

merged 2 commits into from
Sep 3, 2023

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Sep 3, 2023 •
edited
Loading

Changes

During implementation, these variables were moved to TemporalMetricStorage but forgot to remove them from here. Apologies for the oversight.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team September 3, 2023 07:27
@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Merging #2294 (de64cde) into main (01e6581) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2294      +/-   ##
==========================================
- Coverage   87.53%   87.52%   -0.01%     
==========================================
  Files         199      199              
  Lines        5981     5981              
==========================================
- Hits         5235     5234       -1     
- Misses        746      747       +1
Files Changed Coverage
...ntelemetry/sdk/metrics/state/sync_metric_storage.h ø

esigo
esigo approved these changes Sep 3, 2023
View reviewed changes
Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks :)

@esigo esigo added the ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve) label Sep 3, 2023
marcalff
marcalff approved these changes Sep 3, 2023
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff merged commit 5acaa14 into open-telemetry:main Sep 3, 2023
44 checks passed
@marcalff marcalff changed the title [Metrics SDK] Remove unused member variables from SyncMetricStorage [SDK] Remove unused member variables from SyncMetricStorage Oct 11, 2023
@chenrui333 chenrui333 mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esigo esigo esigo approved these changes

@marcalff marcalff marcalff approved these changes

@owent owent owent approved these changes

Assignees
No one assigned
Labels
ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lalitb @owent @marcalff @esigo