Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added public link of opentelemetry_proto_grpc against [shared] gRPC lib #2268

Merged
merged 3 commits into from
Aug 21, 2023
Merged

added public link of opentelemetry_proto_grpc against [shared] gRPC lib #2268

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d415c7
added public link of `opentelemetry_proto_grpc` against gRPC lib [onl…
ays7 Aug 16, 2023
81e2867
Merge branch 'main' into grpc-shlib
lalitb Aug 16, 2023
cd12356
Merge branch 'main' into grpc-shlib
lalitb Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cmake/opentelemetry-proto.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,14 @@ if(WITH_OTLP_GRPC)
${LOGS_SERVICE_GRPC_PB_CPP_FILE} ${METRICS_SERVICE_GRPC_PB_CPP_FILE})

list(APPEND OPENTELEMETRY_PROTO_TARGETS opentelemetry_proto_grpc)
target_link_libraries(opentelemetry_proto_grpc PUBLIC opentelemetry_proto)
target_link_libraries(opentelemetry_proto_grpc
PUBLIC opentelemetry_proto)

get_target_property(grpc_lib_type gRPC::grpc++ TYPE)
if (grpc_lib_type STREQUAL "SHARED_LIBRARY")
target_link_libraries(opentelemetry_proto_grpc
PUBLIC gRPC::grpc++)
endif()
set_target_properties(opentelemetry_proto_grpc PROPERTIES EXPORT_NAME
proto_grpc)
patch_protobuf_targets(opentelemetry_proto_grpc)
Expand Down