-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEST] Expand api singleton test to cover explicit dlopen(). #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcalff
changed the title
[TEST] Expand api singleton test to cover libraries loaded with dlopen().
[WIP][TEST] Expand api singleton test to cover libraries loaded with dlopen().
May 30, 2023
marcalff
changed the title
[WIP][TEST] Expand api singleton test to cover libraries loaded with dlopen().
[WIP][TEST] Expand api singleton test to cover explicit dlopen().
May 30, 2023
marcalff
changed the title
[WIP][TEST] Expand api singleton test to cover explicit dlopen().
[TEST] Expand api singleton test to cover explicit dlopen().
May 30, 2023
Fix works for CMake. For bazel, blocked by bazelbuild/bazel#4218 |
Now ready for review. |
lalitb
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Sorry for the delay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)
Changes
No change in production code, unit test only.
Expand the api singleton test to cover libraries:
dlopen()
The test case added is only available when building with
CMake
.When building with
bazel
, the test case is commented, due to an existing limitation ofbazel
.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes