[BUILD] Add missing target dependencies #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2128 +/- ##
==========================================
+ Coverage 87.17% 87.19% +0.03%
==========================================
Files 166 166
Lines 4784 4784
==========================================
+ Hits 4170 4171 +1
+ Misses 614 613 -1 |
owent
reviewed
May 3, 2023
| @@ -36,7 +36,8 @@ if(WITH_OTLP_GRPC) | |||
|
|
|||
| target_link_libraries( | |||
| opentelemetry_exporter_otlp_grpc_client | |||
| PUBLIC opentelemetry_sdk opentelemetry_ext opentelemetry_proto) | |||
| PUBLIC opentelemetry_sdk opentelemetry_common opentelemetry_ext | |||
There was a problem hiding this comment.
This problem is already fixed in #2097 .
There was a problem hiding this comment.
Please correct me otherwise, but I don't see this is fixed with #2097. Also validated by building shared libs from that PR, and below is the result:
$ ldd -r -d libopentelemetry_*so 2>&1 | grep undefin
undefined symbol: _ZNK13opentelemetry2v13sdk8resource8Resource13GetAttributesEv (./libopentelemetry_exporter_ostream_metrics.so)
undefined symbol: _ZN13opentelemetry2v13sdk6common12internal_log16GlobalLogHandler18GetHandlerAndLevelEv (./libopentelemetry_exporter_otlp_grpc_client.so)
undefined symbol: _ZN13opentelemetry2v13sdk6common12internal_log16GlobalLogHandler18GetHandlerAndLevelEv (./libopentelemetry_http_client_curl.so)
undefined symbol: _ZN13opentelemetry2v13sdk6common12internal_log16GlobalLogHandler18GetHandlerAndLevelEv (./libopentelemetry_exporter_otlp_http_client.so)
undefined symbol: _ZN13opentelemetry2v13sdk6common12internal_log16GlobalLogHandler18GetHandlerAndLevelEv (./libopentelemetry_http_client_curl.so)
undefined symbol: _ZN4grpc24g_core_codegen_interfaceE (./libopentelemetry_proto_grpc.so)
undefined symbol: _ZN4grpc6g_glipE (./libopentelemetry_proto_grpc.so)
undefined symbol: _ZN4absl12lts_202103245MutexD1Ev (./libopentelemetry_proto_grpc.so)
There was a problem hiding this comment.
Sorry, I mean the proto dependency of opentelemetry_exporter_otlp_grpc_client is added in #2097 . I didn't see opentelemetry_common before and it's still useful.
I can solve the conflict later.
lalitb
commented
May 3, 2023
| @@ -467,7 +467,7 @@ update the semantic convention in instrumentation library is needed. | |||
| * [BUILD] Don't require applications using jaeger exporter to know about libcurl | |||
| [#1518](https://github.com/open-telemetry/opentelemetry-cpp/pull/1518) | |||
| * [EXPORTER] Inline print_value() in ostream exporter [#1512](https://github.com/open-telemetry/opentelemetry-cpp/pull/1512) | |||
| * [SDK] fix: urlPaser will incorrect parsing url like "http://abc.com/xxx@xxx/a/b" | |||
| * [SDK] fix: urlPaser will incorrect parsing url like `http://abc.com/xxx@xxx/a/b` | |||
There was a problem hiding this comment.
The CI is failing for bare URL here, so fixing this.
owent
approved these changes
May 3, 2023
| @@ -36,7 +36,8 @@ if(WITH_OTLP_GRPC) | |||
|
|
|||
| target_link_libraries( | |||
| opentelemetry_exporter_otlp_grpc_client | |||
| PUBLIC opentelemetry_sdk opentelemetry_ext opentelemetry_proto) | |||
| PUBLIC opentelemetry_sdk opentelemetry_common opentelemetry_ext | |||
There was a problem hiding this comment.
Sorry, I mean the proto dependency of opentelemetry_exporter_otlp_grpc_client is added in #2097 . I didn't see opentelemetry_common before and it's still useful.
I can solve the conflict later.
ThomsonTan
approved these changes
May 3, 2023
marcalff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2113
Changes
Fixes missing target dependencies for 3 libraries:
Before fix:
After fix:
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes