Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Export factory class of log provider #2041

Merged
merged 2 commits into from
Mar 13, 2023
Merged

[API] Export factory class of log provider #2041

merged 2 commits into from
Mar 13, 2023

Conversation

ThomsonTan
Copy link
Contributor

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented Mar 10, 2023 •
edited
Loading

Codecov Report

Merging #2041 (68a4bc7) into main (1ac9caf) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2041   +/-   ##
=======================================
  Coverage   87.32%   87.32%           
=======================================
  Files         166      166           
  Lines        4723     4723           
=======================================
  Hits         4124     4124           
  Misses        599      599

@lalitb lalitb marked this pull request as ready for review March 13, 2023 20:04
@lalitb lalitb requested a review from a team March 13, 2023 20:04
@esigo esigo added the ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve) label Mar 13, 2023
@ThomsonTan ThomsonTan merged commit b046764 into open-telemetry:main Mar 13, 2023
@marcalff marcalff changed the title Export factory class of log provider [API] Export factory class of log provider Apr 12, 2023
@chuanchan1116 chuanchan1116 mentioned this pull request Apr 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esigo esigo esigo approved these changes

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThomsonTan @lalitb @esigo