Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Remove separate run of metrics ostream example #2030

Merged
merged 4 commits into from
Mar 9, 2023

Conversation

ThomsonTan
Copy link
Contributor

Fixes #1952

Changes

It is no longer needed to run the metrics ostream example in CI.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team March 8, 2023 17:44
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

ci/do_ci.sh Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #2030 (331a9dd) into main (7db57f9) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2030   +/-   ##
=======================================
  Coverage   87.32%   87.32%           
=======================================
  Files         166      166           
  Lines        4723     4723           
=======================================
  Hits         4124     4124           
  Misses        599      599           

@lalitb lalitb self-requested a review March 8, 2023 18:26
@ThomsonTan ThomsonTan merged commit 5046443 into open-telemetry:main Mar 9, 2023
@ThomsonTan ThomsonTan deleted the RemoveSeprateSampleRun branch March 9, 2023 17:38
@marcalff marcalff changed the title Remove separate run of metrics ostream example [CI] Remove separate run of metrics ostream example Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run metrics_ostream_example separately in bazel.asan/tsan?
3 participants