Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Marc as maintainer. #2027

Merged
merged 5 commits into from
Apr 14, 2023
Merged

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Mar 8, 2023

Changes

Add Marc as maintainer.

@marcalff marcalff requested a review from a team March 8, 2023 09:43
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #2027 (a2da096) into main (6a3ee16) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2027      +/-   ##
==========================================
+ Coverage   87.17%   87.19%   +0.03%     
==========================================
  Files         166      166              
  Lines        4784     4784              
==========================================
+ Hits         4170     4171       +1     
+ Misses        614      613       -1     

see 1 file with indirect coverage changes

@lalitb
Copy link
Member

lalitb commented Mar 23, 2023

As discussed in the separate maintainers meeting, everyone was supporting of having Marc as maintainer. However, before we proceed, there are a few prerequisites that need to be addressed by our existing maintainers, to ensure our project is properly prepared to accommodate a new maintainer.

  • Firstly, it is essential that we establish a clear project plan that outlines the project's objectives, milestones, and deliverables. This will provide us with a shared understanding of our project's direction and help us to prioritize our work accordingly. (action on @esigo )

  • We must prioritize and triage issues effectively. By doing so, we will identify the most pressing issues that require attention and ensure that our team's efforts are directed towards high-impact items. (action @esigo)

  • Lastly, it is imperative that we improve our existing merge process. As our codebase grows, we need to ensure that we have a structured approach to merging code changes. One way to do this would be to define the size of pull requests (PRs) and then define merge requirements accordingly. Or for instance, have threshold for PR size and then require mandatory reviewers for each component. (action @lalitb)

We should aim to finish these tasks by early next month, enabling us to add Marc as the maintainer sooner.

During the interim period, we all agreed to that Marc should have necessary maintainer permissions, such as the ability to merge PRs, so that he can effectively handle the responsibility.

If there's anything I overlooked, please include it. I support the approval of this PR based on the provided reasoning, and we can proceed with merging it once we have addressed the above issues.

@lalitb lalitb added the pr:do-not-merge This PR is not ready to be merged. label Mar 23, 2023
Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.
Looking forward to having you as maintainer :)

@esigo
Copy link
Member

esigo commented Mar 26, 2023

@open-telemetry/cpp-maintainers is the project visible?
https://github.com/orgs/open-telemetry/projects/47/views/1

@lalitb lalitb removed the pr:do-not-merge This PR is not ready to be merged. label Apr 14, 2023
@marcalff marcalff merged commit 7cb7654 into open-telemetry:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants