-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Marc as maintainer. #2027
Add Marc as maintainer. #2027
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2027 +/- ##
==========================================
+ Coverage 87.17% 87.19% +0.03%
==========================================
Files 166 166
Lines 4784 4784
==========================================
+ Hits 4170 4171 +1
+ Misses 614 613 -1 |
As discussed in the separate maintainers meeting, everyone was supporting of having Marc as maintainer. However, before we proceed, there are a few prerequisites that need to be addressed by our existing maintainers, to ensure our project is properly prepared to accommodate a new maintainer.
We should aim to finish these tasks by early next month, enabling us to add Marc as the maintainer sooner. During the interim period, we all agreed to that Marc should have necessary maintainer permissions, such as the ability to merge PRs, so that he can effectively handle the responsibility. If there's anything I overlooked, please include it. I support the approval of this PR based on the provided reasoning, and we can proceed with merging it once we have addressed the above issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
Looking forward to having you as maintainer :)
@open-telemetry/cpp-maintainers is the project visible? |
Changes
Add Marc as maintainer.