Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics SDK] Small fix in variable names in Sync Instrument unit tests #1987

Merged
merged 3 commits into from
Feb 17, 2023

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Feb 16, 2023

Changes

Found while doing some performance tests on metrics.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team February 16, 2023 03:22
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #1987 (7f5b8e0) into main (e47dec5) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 7f5b8e0 differs from pull request most recent head a199036. Consider uploading reports for the commit a199036 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1987      +/-   ##
==========================================
+ Coverage   87.11%   87.13%   +0.03%     
==========================================
  Files         166      166              
  Lines        4597     4597              
==========================================
+ Hits         4004     4005       +1     
+ Misses        593      592       -1     
Impacted Files Coverage Δ
sdk/src/trace/batch_span_processor.cc 91.48% <0.00%> (+0.78%) ⬆️

@lalitb lalitb changed the title Small fix in variable names in Sync Instrument unit tests [Metrics SDK] Small fix in variable names in Sync Instrument unit tests Feb 16, 2023
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lalitb lalitb enabled auto-merge (squash) February 17, 2023 01:30
@lalitb lalitb merged commit 01eac4c into open-telemetry:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants