Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in packages.cmake causing incorrect nuget package versions #1936

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Fix typo in packages.cmake causing incorrect nuget package versions #1936

merged 1 commit into from
Jan 23, 2023

Conversation

bret-dusseault-ggl
Copy link
Contributor

@bret-dusseault-ggl bret-dusseault-ggl commented Jan 23, 2023 •
edited by marcalff
Loading

Fixes #1935

Changes

Fixed version line in package.cmake to correctly use the open telemetry version variable.

@bret-dusseault-ggl bret-dusseault-ggl requested a review from a team January 23, 2023 21:34
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 23, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

lalitb
lalitb approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this :)

esigo
esigo approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the fix :)

@esigo esigo added the ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve) label Jan 23, 2023
@esigo esigo enabled auto-merge (squash) January 23, 2023 21:41
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #1936 (043de2e) into main (998badd) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1936   +/-   ##
=======================================
  Coverage   87.12%   87.12%           
=======================================
  Files         165      165           
  Lines        4596     4596           
=======================================
  Hits         4004     4004           
  Misses        592      592

@esigo esigo merged commit 52309dd into open-telemetry:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esigo esigo esigo approved these changes

@marcalff marcalff marcalff approved these changes

@lalitb lalitb lalitb approved these changes

@ThomsonTan ThomsonTan ThomsonTan approved these changes

Assignees
No one assigned
Labels
ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

package.cmake has a typo causing nuget packages to generate incorrect versions.
5 participants
@bret-dusseault-ggl @ThomsonTan @lalitb @marcalff @esigo