Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning for misconfiguration of PeriodicExportingMetricReader #1929

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Fix warning for misconfiguration of PeriodicExportingMetricReader #1929

merged 1 commit into from
Jan 18, 2023

Conversation

jwbuurlage
Copy link
Contributor

Changes

The periodically exporting metric reader requires the timeout field to be strictly less than the interval field. However, the warning that is logged out gives the opposite requirement. The existing logic in the code is correct.

Fix warning for misconfiguration of PeriodicExportingMetricReader
b3242df 
The periodically exporting metric reader requires the timeout field to be strictly less than the interval field. However, the warning that is logged out gives the opposite requirement. The existing logic in the code is correct.
@jwbuurlage jwbuurlage requested a review from a team January 18, 2023 14:55
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 18, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jwbuurlage / name: Jan-Willem Buurlage (b3242df)

lalitb
lalitb approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@lalitb lalitb enabled auto-merge (squash) January 18, 2023 15:07
marcalff
marcalff approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@lalitb lalitb merged commit c9e76b4 into open-telemetry:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcalff marcalff marcalff approved these changes

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jwbuurlage @lalitb @marcalff