-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Aggregation support #1899
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1899 +/- ##
==========================================
+ Coverage 86.90% 87.12% +0.23%
==========================================
Files 165 165
Lines 4594 4596 +2
==========================================
+ Hits 3992 4004 +12
+ Misses 602 592 -10
|
@mprzybylski Have created a draft PR, if you want to test this. Haven't added all unit-test scenarios, basically blocked on #1869 to be merged before adding tests for histogram aggregation. But should be good enough to test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
just had one nit comment.
Thanks for the PR :)
Fixes #1664
Changes
This is ready to review now. With the change, it is possible to use the custom aggregator for the Instruments.
Also added tests for:
As a side change, it fixes few warning for unused variables.
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes