-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI benchmark #1799
Fix CI benchmark #1799
Conversation
@open-telemetry/cpp-approvers This is a blind fix, it can not be tested on PR push, Most likely it will fix the break, |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1799 +/- ##
==========================================
- Coverage 85.79% 85.71% -0.07%
==========================================
Files 171 171
Lines 5240 5240
==========================================
- Hits 4495 4491 -4
- Misses 745 749 +4
|
Can we run benchmark on PR build too? |
It was removed from PR build purposefully, in order to not have heavy load on servers when benchmark test is running. |
That would pollute our benchmark graphs. |
To clarify, this fixes: |
Fixes #1800
Changes
Fix
OpenTelemetry-cpp benchmarks / Run OpenTelemetry-cpp benchmarks
in CIThe ubuntu-latest upgrade from 20.04 to 22.04 broke benchmarks.
Restoring ubuntu-20.04
CHANGELOG.md
updated for non-trivial changes