Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI benchmark #1799

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Fix CI benchmark #1799

merged 1 commit into from
Nov 23, 2022

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Nov 23, 2022

Fixes #1800

Changes

Fix OpenTelemetry-cpp benchmarks / Run OpenTelemetry-cpp benchmarks in CI

The ubuntu-latest upgrade from 20.04 to 22.04 broke benchmarks.
Restoring ubuntu-20.04

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team November 23, 2022 19:36
@marcalff
Copy link
Member Author

@open-telemetry/cpp-approvers

This is a blind fix, it can not be tested on PR push,
because the benchmark workflow runs on main only.

Most likely it will fix the break,
and if not it will be trivial to revert anyway.

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #1799 (2f76ff6) into main (6ba1f73) will decrease coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1799      +/-   ##
==========================================
- Coverage   85.79%   85.71%   -0.07%     
==========================================
  Files         171      171              
  Lines        5240     5240              
==========================================
- Hits         4495     4491       -4     
- Misses        745      749       +4     
Impacted Files Coverage Δ
ext/src/http/client/curl/http_client_curl.cc 80.31% <0.00%> (-1.13%) ⬇️
sdk/src/trace/batch_span_processor.cc 90.63% <0.00%> (-0.78%) ⬇️

@ThomsonTan
Copy link
Contributor

@open-telemetry/cpp-approvers

This is a blind fix, it can not be tested on PR push, because the benchmark workflow runs on main only.

Most likely it will fix the break, and if not it will be trivial to revert anyway.

Can we run benchmark on PR build too?

@lalitb
Copy link
Member

lalitb commented Nov 23, 2022

Can we run benchmark on PR build too?

It was removed from PR build purposefully, in order to not have heavy load on servers when benchmark test is running.

@esigo
Copy link
Member

esigo commented Nov 23, 2022

@open-telemetry/cpp-approvers
This is a blind fix, it can not be tested on PR push, because the benchmark workflow runs on main only.
Most likely it will fix the break, and if not it will be trivial to revert anyway.

Can we run benchmark on PR build too?

That would pollute our benchmark graphs.

@marcalff
Copy link
Member Author

To clarify, this fixes:
OpenTelemetry-cpp benchmarks / Run OpenTelemetry-cpp benchmarks
not to be confused with
CI / Benchmark

@esigo esigo merged commit c1aa0b8 into open-telemetry:main Nov 23, 2022
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
@marcalff marcalff deleted the fix_ci_benchmark branch July 4, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Benchmarks broken by ubuntu-latest upgrade
4 participants