Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI build #1798

Merged
merged 4 commits into from
Nov 23, 2022
Merged

Fix CI build #1798

merged 4 commits into from
Nov 23, 2022

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Nov 23, 2022

Fixes #1791

Changes

Fix CI build

ubuntu-latest upgraded from 20.04 to 22.04

ubuntu-20.04, used in CI before, had gcc 9 and gcc 10
ubuntu-22.04, used in CI now, has gcc 9, gcc 10 and gcc 11

Use gcc 10 instead of gcc 11 on ubuntu 22.04 (now latest), where this is sufficient.
Use ubuntu-20.04 when more dependencies fail (asan, abseil, grpc)

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team November 23, 2022 10:28
@marcalff marcalff changed the title Fix CI build. Fix CI build Nov 23, 2022
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #1798 (e55fd81) into main (6644ddd) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1798      +/-   ##
==========================================
- Coverage   85.73%   85.73%   -0.00%     
==========================================
  Files         171      171              
  Lines        5220     5240      +20     
==========================================
+ Hits         4475     4492      +17     
- Misses        745      748       +3     
Impacted Files Coverage Δ
api/include/opentelemetry/common/timestamp.h 80.44% <0.00%> (-0.81%) ⬇️
ext/src/http/client/curl/http_operation_curl.cc 75.54% <0.00%> (-0.49%) ⬇️
api/include/opentelemetry/trace/tracer.h 100.00% <0.00%> (ø)
api/include/opentelemetry/trace/span_context.h 100.00% <0.00%> (ø)
...i/include/opentelemetry/metrics/sync_instruments.h 100.00% <0.00%> (ø)
...nclude/opentelemetry/sdk/metrics/data/point_data.h 100.00% <0.00%> (ø)
.../opentelemetry/nostd/internal/absl/types/variant.h 100.00% <0.00%> (ø)
api/include/opentelemetry/common/kv_properties.h 98.97% <0.00%> (+0.02%) ⬆️
...metry/nostd/internal/absl/types/internal/variant.h 71.69% <0.00%> (+0.13%) ⬆️
...pentelemetry/trace/span_context_kv_iterable_view.h 84.22% <0.00%> (+1.86%) ⬆️
... and 1 more

@esigo esigo enabled auto-merge (squash) November 23, 2022 16:50
Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the quick fix :)

@esigo esigo merged commit 0dc2268 into open-telemetry:main Nov 23, 2022
@lalitb
Copy link
Member

lalitb commented Nov 23, 2022

Use gcc 10 instead of gcc 11 on ubuntu 22.04 (now latest), where this is sufficient.
Use ubuntu-20.04 when more dependencies fail (asan, abseil, grpc)

Sorry, I am not fully in sync with the changes, so asking - There are issues in building the latest versions of asan, abeil and gRPC with gcc11, So we are using gcc 10 at all places ?

@ThomsonTan
Copy link
Contributor

Should it be added to doc if our repo doesn't work with gcc-11?

Use gcc 10 instead of gcc 11 on ubuntu 22.04 (now latest), where this is sufficient.
Use ubuntu-20.04 when more dependencies fail (asan, abseil, grpc)

Sorry, I am not fully in sync with the changes, so asking - There are issues in building the latest versions of asan, abeil and gRPC with gcc11, So we are using gcc 10 at all places ?

yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
@marcalff marcalff deleted the fix_ci_ubuntu branch July 4, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI is broken because of new GHA image
4 participants