Add MeterContext::ForEachMeter() method to process callbacks on Meter in thread-safe manner #1783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1720
Changes
Another approach to fix #1720 (refer #1777 for first approach) by adding
MeterContext::ForEachMeter
, which invokes callback to process each meter in thread-safe manner. This will ensure that metric collection doesn't crash for existing meters while new meter is being added.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes