Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Upgrade bazel build to use abseil-cpp-20220623.1 #1779

Merged
merged 4 commits into from
Nov 16, 2022

Conversation

marcalff
Copy link
Member

Fixes #1778

Changes

Bazel build:
Upgrade Abseil to abseil-cpp-20220623.1

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Bazel build:
Upgrade Abseil to abseil-cpp-20220623.1
@marcalff marcalff requested a review from a team November 16, 2022 20:44
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #1779 (9b77b27) into main (d7a388b) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1779      +/-   ##
==========================================
+ Coverage   85.77%   85.79%   +0.02%     
==========================================
  Files         171      171              
  Lines        5214     5214              
==========================================
+ Hits         4472     4473       +1     
+ Misses        742      741       -1     
Impacted Files Coverage Δ
sdk/src/trace/batch_span_processor.cc 91.41% <0.00%> (+0.79%) ⬆️

@marcalff marcalff added the pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) label Nov 16, 2022
@marcalff
Copy link
Member Author

CI is complete, merging this should fix the break on macOS in the main branch.

@lalitb lalitb merged commit 8da88df into open-telemetry:main Nov 16, 2022
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
@marcalff marcalff deleted the fix_macos_abseil_1778 branch July 4, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build and test pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUILD] Build break on macOS 12
4 participants