Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format config options in OTLP exporter readme #1748

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

ThomsonTan
Copy link
Contributor

Changes

Format the OTLP exporter config options for better visibility in mark down editor without entering preview mode (help dev cycle).

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team November 8, 2022 23:10
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. it's readable now :)

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #1748 (e6727df) into main (b46ca96) will increase coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1748      +/-   ##
==========================================
+ Coverage   85.73%   85.79%   +0.06%     
==========================================
  Files         171      171              
  Lines        5212     5212              
==========================================
+ Hits         4468     4471       +3     
+ Misses        744      741       -3     
Impacted Files Coverage Δ
ext/src/http/client/curl/http_client_curl.cc 81.44% <0.00%> (+1.14%) ⬆️

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better.

Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lalitb lalitb merged commit a220ac4 into open-telemetry:main Nov 9, 2022
@ThomsonTan ThomsonTan deleted the FormatOtlpReadMe branch November 9, 2022 22:55
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants