Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Removal] Remove deprecated experimental semantic conventions (#1741) #1743

Merged

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Nov 7, 2022

Fixes #1741

Changes

Remove deprecated files:

api/include/opentelemetry/trace/experimental_semantic_conventions.h
sdk/include/opentelemetry/sdk/resource/experimental_semantic_conventions.h

Remove deprecated global function:

  uint32_t hashCode(const char *str, uint32_t h = 0)
  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team November 7, 2022 22:10
@marcalff
Copy link
Member Author

marcalff commented Nov 7, 2022

[DO NOT MERGE], for now.

First, #1744 should be merged and released with version N (Deprecation announcement)
Deprecation announced in 1.8.0

ON HOLD AGAIN: wait for 1.8.1 release first.
Then, #1743 should be merged and released with version N+1 (Removal)

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #1743 (425cefb) into main (41821d6) will decrease coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1743      +/-   ##
==========================================
- Coverage   85.79%   85.73%   -0.05%     
==========================================
  Files         171      171              
  Lines        5240     5240              
==========================================
- Hits         4495     4492       -3     
- Misses        745      748       +3     
Impacted Files Coverage Δ
api/include/opentelemetry/common/string_util.h 100.00% <ø> (ø)
ext/src/http/client/curl/http_client_curl.cc 80.31% <0.00%> (-1.13%) ⬇️

@marcalff marcalff added the pr:do-not-merge This PR is not ready to be merged. label Nov 9, 2022
@marcalff marcalff changed the title [DO NOT MERGE] [Removal] Remove deprecated experimental semantic conventions (#1741) [Removal] Remove deprecated experimental semantic conventions (#1741) Nov 28, 2022
@marcalff marcalff added issue:blocked Fix blocked, waiting for other fixes as prerequisites pr:do-not-merge This PR is not ready to be merged. and removed pr:do-not-merge This PR is not ready to be merged. issue:blocked Fix blocked, waiting for other fixes as prerequisites labels Nov 28, 2022
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the PR :)

@lalitb lalitb merged commit 7727620 into open-telemetry:main Dec 8, 2022
@marcalff marcalff deleted the remove_experimental_semconv_1741 branch July 4, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Removal] Remove deprecated experimental semantic conventions.
3 participants