Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Marc Alff in cpp-approvers #1635

Merged
merged 3 commits into from
Sep 27, 2022
Merged

Add Marc Alff in cpp-approvers #1635

merged 3 commits into from
Sep 27, 2022

Conversation

marcalff
Copy link
Member

Add Marc Alff in cpp-approvers

Per discussion in C++ SIG Meeting, 2022-09-26.

@marcalff
Add Marc Alff in cpp-approvers
cdce6da 
Per discussion in C++ SIG Meeting, 2022-09-26.
@marcalff marcalff requested a review from a team September 26, 2022 21:27
reyang
reyang reviewed Sep 26, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
reyang
reyang approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcalff 🥳💯🥇🎆👍

@codecov
Copy link

codecov bot commented Sep 26, 2022 •
edited
Loading

Codecov Report

Merging #1635 (32b921e) into main (5c180a1) will decrease coverage by 0.07%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1635      +/-   ##
==========================================
- Coverage   85.12%   85.06%   -0.06%     
==========================================
  Files         159      159              
  Lines        4999     4999              
==========================================
- Hits         4255     4252       -3     
- Misses        744      747       +3
Impacted Files Coverage Δ
ext/src/http/client/curl/http_client_curl.cc 80.31% <0.00%> (-1.13%) ⬇️

@lalitb
Copy link
Member

lalitb commented Sep 27, 2022

@marcalff - Can you approve this PR too, as acceptance for the role :)

@reyang
Copy link
Member

reyang commented Sep 27, 2022

@marcalff - Can you approve this PR too, as acceptance for the role :)

Having @marcalff approving his own PR? 🤣

@lalitb
Copy link
Member

lalitb commented Sep 27, 2022

Having @marcalff approving his own PR? 🤣

Yes, we have been following this tradition for both approvers and maintainers- #410, #1276, #1183. #936

@lalitb
Copy link
Member

lalitb commented Sep 27, 2022

Having @marcalff approving his own PR? 🤣

Yes, we have been following this tradition for both approvers and maintainers- #410, #1276, #1183. #936

Oh sorry, I didn't notice this was created by @marcalff , I thought it was @esigo . Good to merge.

@lalitb lalitb merged commit 1626436 into open-telemetry:main Sep 27, 2022
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
@marcalff @ThomsonTan @yxue
Add Marc Alff in cpp-approvers (open-telemetry#1635)
324c7ae 
* Add Marc Alff in cpp-approvers

Per discussion in C++ SIG Meeting, 2022-09-26.

* Order by name.

Co-authored-by: Tom Tan <Tom.Tan@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esigo esigo esigo approved these changes

@reyang reyang reyang approved these changes

@lalitb lalitb lalitb approved these changes

@ThomsonTan ThomsonTan ThomsonTan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marcalff @lalitb @reyang @ThomsonTan @esigo