Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LoggerContext::Shutdown and tsan of OtlpHttpClient #1592

Merged
merged 2 commits into from
Sep 6, 2022

Conversation

owent
Copy link
Member

@owent owent commented Sep 5, 2022

Signed-off-by: owent admin@owent.net

Fixes #1591
Fixes #1558

Changes

  • Add SimpleLogProcessor::IsShutdown for unit test
  • Fix shutdown call
  • Fix tsan when destroying OtlpHttpClient

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Signed-off-by: owent <admin@owent.net>
@owent owent requested a review from a team September 5, 2022 11:18
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #1592 (9dfe401) into main (5788287) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1592   +/-   ##
=======================================
  Coverage   85.02%   85.02%           
=======================================
  Files         156      156           
  Lines        4977     4977           
=======================================
  Hits         4231     4231           
  Misses        746      746           

Signed-off-by: owent <admin@owent.net>
@owent owent changed the title Fix LoggerContext::Shutdown Fix LoggerContext::Shutdown and tsan of OtlpHttpClient Sep 5, 2022
Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the fix :)

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@ThomsonTan ThomsonTan merged commit b520480 into open-telemetry:main Sep 6, 2022
@owent owent deleted the fix_1591 branch September 9, 2022 06:42
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants