-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OTLP exporter #152
Add OTLP exporter #152
Conversation
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
=======================================
Coverage 93.61% 93.61%
=======================================
Files 71 71
Lines 1754 1754
=======================================
Hits 1642 1642
Misses 112 112 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good!
@pyohannes Please let me know if you have any other comments! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I have two more nits, otherwise this is ready to merge.
@reyang Ready to merge! |
@nadiaciobanu would you rebase? |
Add an OTLP exporter that exports spans to the OpenTelemetry Collector via gRPC. Note that this requires adding a gRPC dependency to
opentelemetry-cpp
.