Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to deprecated InstrumentationLibrary in OTLP #1469

Merged

Conversation

ThomsonTan
Copy link
Contributor

Fixes #1381

We upgraded OTLP proto files to 0.17.0, but we are still using InstrumentationLibrary in the OTLP message which was marked as deprecated, and this deprecated field is not compatible with previous OTLP message in wired format.

This PR replaces InstrumentationLibrary by InstrumentationScope in the OTLP exporter to fix the broken compatibility. Fix for the SDK is expected to be in future PR.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team June 29, 2022 18:29
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #1469 (adb7024) into main (b285874) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1469   +/-   ##
=======================================
  Coverage   85.30%   85.30%           
=======================================
  Files         154      154           
  Lines        4374     4374           
=======================================
  Hits         3731     3731           
  Misses        643      643           

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@ThomsonTan ThomsonTan changed the title Removing reference to deprecated InstrumentationLibrary in OTLP Remove reference to deprecated InstrumentationLibrary in OTLP Jun 29, 2022
@ThomsonTan ThomsonTan merged commit 45fdbf2 into open-telemetry:main Jun 29, 2022
@ThomsonTan ThomsonTan deleted the FixInstrumentationLibraryInOtlp branch June 29, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add InstrumentationScope and deprecate InstrumentationLibrary
2 participants