Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare v1.4.1 patch release #1458

Merged
merged 3 commits into from
Jun 20, 2022
Merged

Prepare v1.4.1 patch release #1458

merged 3 commits into from
Jun 20, 2022

Conversation

ThomsonTan
Copy link
Contributor

Changes

Prepare for v1.4.1 patch release.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team June 19, 2022 16:42
@codecov
Copy link

codecov bot commented Jun 19, 2022 •
edited
Loading

Codecov Report

Merging #1458 (def5297) into main (9f3a8ee) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1458   +/-   ##
=======================================
  Coverage   85.30%   85.30%           
=======================================
  Files         154      154           
  Lines        4373     4373           
=======================================
  Hits         3730     3730           
  Misses        643      643

owent
owent reviewed Jun 20, 2022
View reviewed changes
sdk/src/version/version.cc Outdated Show resolved Hide resolved
owent
owent approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

marcalff
marcalff approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThomsonTan ThomsonTan merged commit 96534a7 into open-telemetry:main Jun 20, 2022
@ThomsonTan ThomsonTan deleted the pre_release_1.4.1 branch June 20, 2022 22:16
@ThomsonTan ThomsonTan mentioned this pull request Jun 20, 2022
Closed
@marcalff marcalff mentioned this pull request Aug 2, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcalff marcalff marcalff approved these changes

@owent owent owent approved these changes

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ThomsonTan @lalitb @owent @marcalff