Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics SDK] Remove un-necessary files. #1379

Merged
merged 4 commits into from
May 7, 2022
Merged

[Metrics SDK] Remove un-necessary files. #1379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
83efe63
remove files not required
lalitb May 7, 2022
8d1962f
Merge branch 'main' into delete-files-not-required
lalitb May 7, 2022
1ba41bc
remove file
lalitb May 7, 2022
9d29744
Merge branch 'delete-files-not-required' of github.com:lalitb/opentel…
lalitb May 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions exporters/ostream/include/opentelemetry/exporters/ostream/metric_exporter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,9 @@
# include <iostream>
# include <string>
# include "opentelemetry/common/spin_lock_mutex.h"
# include "opentelemetry/nostd/span.h"
# include "opentelemetry/sdk/metrics/data/metric_data.h"
# include "opentelemetry/sdk/metrics/instruments.h"
# include "opentelemetry/sdk/metrics/metric_exporter.h"
# include "opentelemetry/sdk/metrics/recordable.h"
# include "opentelemetry/version.h"

OPENTELEMETRY_BEGIN_NAMESPACE
Expand All @@ -28,7 +26,7 @@ class OStreamMetricExporter final : public opentelemetry::sdk::metrics::MetricEx
public:
/**
* Create an OStreamMetricExporter. This constructor takes in a reference to an ostream that the
* export() function will send span data into.
* export() function will send metrics data into.
* The default ostream is set to stdout
*/
explicit OStreamMetricExporter(std::ostream &sout = std::cout) noexcept;
Expand Down
24 changes: 0 additions & 24 deletions sdk/include/opentelemetry/sdk/metrics/aggregator/aggregator.h
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion sdk/include/opentelemetry/sdk/metrics/metric_exporter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class MetricExporter
virtual ~MetricExporter() = default;

/**
* Exports a batch of metrics recordables. This method must not be called
* Exports a batch of metrics data. This method must not be called
* concurrently for the same exporter instance.
* @param data metrics data
*/
Expand Down
26 changes: 0 additions & 26 deletions sdk/include/opentelemetry/sdk/metrics/recordable.h
View file
Open in desktop

This file was deleted.