Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build warnings about missing aggregates #1368

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

taekahn
Copy link
Contributor

@taekahn taekahn commented May 3, 2022

Fixes # (issue)

Changes

Fixing a build warning about missing initialize for aggregate initialization.

@taekahn taekahn requested a review from a team May 3, 2022 21:34
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 3, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #1368 (7b84c25) into main (45fdbf2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1368   +/-   ##
=======================================
  Coverage   85.30%   85.30%           
=======================================
  Files         154      154           
  Lines        4374     4374           
=======================================
  Hits         3731     3731           
  Misses        643      643           
Impacted Files Coverage Δ
sdk/src/trace/samplers/trace_id_ratio.cc 100.00% <100.00%> (ø)

@ThomsonTan
Copy link
Contributor

@taekahn thanks for the fix. Could you please help fix the CLA issue?

@taekahn
Copy link
Contributor Author

taekahn commented May 17, 2022

@taekahn thanks for the fix. Could you please help fix the CLA issue?

I'm not sure what i have to do. I clicked on the link in the bot message and signed the form 3 times.

@lalitb
Copy link
Member

lalitb commented Jun 1, 2022

@taekahn Can you sign up for EasyCLA so that we can merge the PR ?

@taekahn
Copy link
Contributor Author

taekahn commented Jun 1, 2022

@taekahn Can you sign up for EasyCLA so that we can merge the PR ?

As i said above, i clicked on the link. Registered. Signed the form several times.
Not sure what more i need to do in this regard.

@marcalff
Copy link
Member

marcalff commented Jul 1, 2022

The commit is:

Jeffrey Reynolds authored and taekahn committed on May 18

It could be that the missing CLA and id is about Jeffrey, not taekahn.

@lalitb lalitb merged commit 7b0bb14 into open-telemetry:main Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants