Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix errors in SDK documentation #1201

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

esigo
Copy link
Member

@esigo esigo commented Feb 9, 2022

Fixes #1199 (issue)

Changes

fix errors in SDK documentation for trace provider, resource_attributes and samplers.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@esigo esigo requested a review from a team February 9, 2022 20:09
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #1201 (4edc9b9) into main (44795b6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1201   +/-   ##
=======================================
  Coverage   93.44%   93.44%           
=======================================
  Files         185      185           
  Lines        6720     6720           
=======================================
  Hits         6279     6279           
  Misses        441      441           

@lalitb lalitb merged commit e1c8557 into open-telemetry:main Feb 9, 2022
@esigo esigo deleted the Errors-in-SDK-documentation branch February 9, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors in SDK documentation
2 participants