Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elasticsearch Log exporter "resources" are under "resources" key while it should be under the "root" #3119

Open
ShadowMaxLeb opened this issue Nov 4, 2024 · 1 comment · May be fixed by #3131
Open

Elasticsearch Log exporter "resources" are under "resources" key while it should be under the "root" #3119

ShadowMaxLeb opened this issue Nov 4, 2024 · 1 comment · May be fixed by #3131
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@ShadowMaxLeb
Copy link
Contributor

Not exactly a bug but this is to continue the work I have done here #3091

It is open to discussion but I think, like for attributes that resources should also be by default in the root object and that it would be up to the user to add different levels if necessary.

This would make sense as for instance in the resources we would put user.id which is common to all logs and that would not make sense to "manually" add it through the log attributes every time we call EmitLogRecord
@ShadowMaxLeb ShadowMaxLeb added the bug Something isn't working label Nov 4, 2024
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 4, 2024
@marcalff marcalff added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 4, 2024
@ShadowMaxLeb
Copy link
Contributor Author

@marcalff any thoughts on this ? Should I make a PR so we can discuss it ?

ShadowMaxLeb added a commit to Shadow-Official/opentelemetry-cpp that referenced this issue Nov 6, 2024
@ShadowMaxLeb
[EXPORTER]: Elasticsearch exporter put log resource in root instead of
f9ade0a 
under 'resources'

Closes open-telemetry#3119
@ShadowMaxLeb ShadowMaxLeb linked a pull request Nov 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
2 participants
@marcalff @ShadowMaxLeb