Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between Bazel & CMake #2072

Open
cngzhnp opened this issue Mar 27, 2023 · 2 comments
Open

Inconsistency between Bazel & CMake #2072

cngzhnp opened this issue Mar 27, 2023 · 2 comments
Labels
bug Something isn't working do-not-stale good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers

Comments

@cngzhnp
Copy link
Contributor

cngzhnp commented Mar 27, 2023

Describe your environment In OTLP project, there are two different build mechanisms which one of them could be used for compilation different targets. Also, it would be helpful to maintain different third party packages from their source codes.

Steps to reproduce
For CMake, there is a file(third_party_release) which contains which third party library is linked with which version. Same for Bazel, the file(repository.bzl) contains same information. However, both file contains different third-party versions as an information.

For example;

  • benchmark=v1.5.3 was defined for CMake but for Bazel it was defined "benchmark-1.6.0".
  • CURL library was not defined as a depedency in the CMake.

What is the expected behavior?
Same versions must be used for even different build mechanisms.

What is the actual behavior?
There are different versions for Bazel and CMake which could cause inconsistency.

Additional context
Add any other context about the problem here.

@cngzhnp cngzhnp added the bug Something isn't working label Mar 27, 2023
@esigo
Copy link
Member

esigo commented Mar 27, 2023

CURL can be removed from bazel and benchmark should use the same version for both CMake and bazel.

@esigo esigo added help wanted Good for taking. Extra help will be provided by maintainers good first issue Good for newcomers labels Mar 27, 2023
@github-actions
Copy link

This issue was marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label May 27, 2023
@lalitb lalitb added do-not-stale and removed Stale labels May 27, 2023
haidong added a commit to haidong/opentelemetry-cpp that referenced this issue Jul 12, 2024
This addresses open-telemetry#2072. The benchmark is consistent between CMake and
bazel. This PR removes the libcurl in repository.bzl.

Signed-off-by: Alex Ji <alji@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working do-not-stale good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants