Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPRECATION] Drop C++11 support #1830

Closed
esigo opened this issue Dec 1, 2022 · 8 comments · Fixed by #2146
Closed

[DEPRECATION] Drop C++11 support #1830

esigo opened this issue Dec 1, 2022 · 8 comments · Fixed by #2146
Assignees
Labels
area:build OpenTelemetry build deprecation Deprecation do-not-stale

Comments

@esigo
Copy link
Member

esigo commented Dec 1, 2022

Following November 30, 2022 SIG meeting, as gRPC and Prometheus require >C++14 and Gtest, abseil will not support C++11 with their next release; it becomes more challenging for us to support C++11.
This will require us to have multiple combination of dependencies tests on our CI.

I suggest to announce the drop of support as soon as we can, and drop the support in 6 months after the announcement.

This issue is for collecting feedback from the users.

@esigo esigo added the area:build OpenTelemetry build label Dec 1, 2022
@esigo esigo self-assigned this Dec 1, 2022
@esigo esigo pinned this issue Dec 1, 2022
@esigo
Copy link
Member Author

esigo commented Dec 5, 2022

Hi @owent, it would be great to have your feedback here. Thanks

@owent
Copy link
Member

owent commented Dec 6, 2022

Hi @owent, it would be great to have your feedback here. Thanks

It would be great if otel-cpp just remove the CI jobs but do not use new features of C++14, I can maintain the gRPC and protobuf in my internal version.

@marcalff marcalff added the deprecation Deprecation label Jan 19, 2023
@esigo esigo mentioned this issue Jan 31, 2023
3 tasks
@ThomsonTan ThomsonTan unpinned this issue Feb 2, 2023
@lalitb lalitb pinned this issue Feb 13, 2023
@lalitb
Copy link
Member

lalitb commented Feb 13, 2023

Plan to announce the deprecation during next release (tentative).

@ThomsonTan
Copy link
Contributor

Hi @owent, it would be great to have your feedback here. Thanks

It would be great if otel-cpp just remove the CI jobs but do not use new features of C++14, I can maintain the gRPC and protobuf in my internal version.

@owent do you need some longer time to migrate to C++14, or no existing plan from your side and will stay on C++ 11 for a while?

@owent
Copy link
Member

owent commented Feb 14, 2023

Hi @owent, it would be great to have your feedback here. Thanks

It would be great if otel-cpp just remove the CI jobs but do not use new features of C++14, I can maintain the gRPC and protobuf in my internal version.

@owent do you need some longer time to migrate to C++14, or no existing plan from your side and will stay on C++ 11 for a while?

We still have some old systems use gcc 4.8(with a lot of binary/prebuilt dependencies and maybe can not upgrade in at least one or two years), it only support part of C++14.
It's fine by me if we just remove the ci jobs and avoid to use the new features gcc 4.8 do not support.I have another tool repo (http://github.com/atframework/cmake-toolset) which will check the compatibility and fix any problem when I find in the future.

@malkia
Copy link

malkia commented Feb 17, 2023

I only hope make_unique and make_shared would slowly get into use :)

@owent
Copy link
Member

owent commented Feb 18, 2023

I only hope make_unique and make_shared would slowly get into use :)

I think we can add nostd::make_unique and nostd::make_shared to replace the direct usage of std::make_unique and std::make_shared.Just like promethues.

@github-actions
Copy link

This issue was marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label Apr 20, 2023
@lalitb lalitb added do-not-stale and removed Stale labels Apr 20, 2023
@marcalff marcalff assigned marcalff and unassigned esigo May 22, 2023
@marcalff marcalff changed the title Drop C++11 support [DEPRECATION] Drop C++11 support May 22, 2023
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue May 22, 2023
@marcalff marcalff added this to the Migrate to C++14 milestone May 23, 2023
@marcalff marcalff unpinned this issue May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:build OpenTelemetry build deprecation Deprecation do-not-stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants