Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics SDK] Threading issue between Meter::RegisterSyncMetricStorage and Meter::Collect #1663

Closed
sam-leitch-oxb opened this issue Oct 7, 2022 · 0 comments · Fixed by #1666
Closed

[Metrics SDK] Threading issue between Meter::RegisterSyncMetricStorage and Meter::Collect #1663

sam-leitch-oxb opened this issue Oct 7, 2022 · 0 comments · Fixed by #1666
Assignees
@lalitb
Labels
bug Something isn't working
Milestone
Metrics v1.0.0 (GA)

Comments

@sam-leitch-oxb
Copy link

Meter::Collect is usually called in a background thread (via PeriodicExportingMetricReader)

Meter::RegisterSyncMetricStorage and Meter::RegisterAsyncMetricStorage are called for each new instrument.

These methods are not thread safe, and can cause SEGFAULT under certain conditions.
@sam-leitch-oxb sam-leitch-oxb added the bug Something isn't working label Oct 7, 2022
@lalitb lalitb added this to the Metrics v1.0.0 (GA) milestone Oct 7, 2022
@lalitb lalitb self-assigned this Oct 7, 2022
@lalitb lalitb mentioned this issue Oct 7, 2022
Merged
3 tasks
ThomsonTan pushed a commit that referenced this issue Oct 11, 2022
@lalitb
Fix #1663 Threading issue between Meter::RegisterSyncMetricStorage an…
99f2ba4 
…d Meter::Collect (#1666)
@ahadnagy ahadnagy mentioned this issue Oct 12, 2022
Closed
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this issue Dec 5, 2022
@lalitb @yxue
Fix open-telemetry#1663 Threading issue between Meter::RegisterSyncMe…
29e050b 
…tricStorage and Meter::Collect (open-telemetry#1666)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lalitb lalitb

Labels
bug Something isn't working
Projects
None yet
Milestone
Metrics v1.0.0 (GA)
2 participants
@lalitb @sam-leitch-oxb