PR comments

open-telemetry · Apr 6, 2020 · ef07670 · ef07670
1 parent 25987a5
commit ef07670
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/sdk/include/opentelemetry/sdk/trace/exporter.h b/sdk/include/opentelemetry/sdk/trace/exporter.h
@@ -17,12 +17,12 @@ enum class ExportResult
   /**
    * Batch was successfully exported.
    */
-  rSuccess = 0,
+  kSuccess = 0,
   /**
    * Exporting failed. The caller must not retry exporting the same batch; the
    * batch must be dropped.
    */
-  rFailure
+  kFailure
 };
 /**
  * SpanExporter defines the interface that protocol-specific span exporters must

diff --git a/sdk/src/trace/simple_processor.h b/sdk/src/trace/simple_processor.h
@@ -36,7 +36,7 @@ class SimpleSpanProcessor : public SpanProcessor
   {
     std::shared_ptr<Recordable> recordable{std::move(span)};
     nostd::span<std::shared_ptr<Recordable>> s(&recordable, 1);
-    if (exporter_->Export(s) == ExportResult::rFailure)
+    if (exporter_->Export(s) == ExportResult::kFailure)
     {
       /* Once it is defined how the SDK does logging, an error should be
        * logged in this case. */

diff --git a/sdk/test/trace/simple_processor_test.cc b/sdk/test/trace/simple_processor_test.cc
@@ -31,7 +31,7 @@ class MockSpanExporter final : public SpanExporter
         *span_received_ = true;
       }
     }
-    return ExportResult::rSuccess;
+    return ExportResult::kSuccess;
   }
 
   void Shutdown() noexcept { *shutdown_called_ = true; }