Exports span attributes to ETW

open-telemetry · Oct 20, 2021 · ed834df · ed834df
1 parent 55a6517
commit ed834df
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/exporters/etw/include/opentelemetry/exporters/etw/etw_tracer.h b/exporters/etw/include/opentelemetry/exporters/etw/etw_tracer.h
@@ -837,9 +837,12 @@ class Span : public trace::Span
    */
   void SetAttribute(nostd::string_view key, const common::AttributeValue &value) noexcept override
   {
-    // TODO: not implemented
-    UNREFERENCED_PARAMETER(key);
-    UNREFERENCED_PARAMETER(value);
+    // don't override fields propagated from span data.
+    if (key == ETW_FIELD_NAME || key == ETW_FIELD_SPAN_ID || key == ETW_FIELD_TRACE_ID)
+    {
+      return;
+    }
+    attributes_[std::string{key}].FromAttributeValue(value);
   }
 
   /**