Add explicit type cast in baggage UrlDecode (#1353)

open-telemetry · Apr 26, 2022 · c917bed · c917bed · github-actions · Apr 26, 2022
1 parent 33cb827
commit c917bed
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/api/include/opentelemetry/baggage/baggage.h b/api/include/opentelemetry/baggage/baggage.h
@@ -249,7 +249,9 @@ class Baggage
     };
 
     auto from_hex = [](char c) -> char {
-      return std::isdigit(c) ? c - '0' : std::toupper(c) - 'A' + 10;
+      // c - '0' produces integer type which could trigger error/warning when casting to char,
+      // but the cast is safe here.
+      return static_cast<char>(std::isdigit(c) ? c - '0' : std::toupper(c) - 'A' + 10);
     };
 
     std::string ret;