Skip to content

Commit

Permalink
[bazel] Fix -std=c++14 warning on Windows (#2601)
Browse files Browse the repository at this point in the history
  • Loading branch information
keith authored Mar 21, 2024
1 parent 3f8d954 commit 8605fe8
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,16 @@
# bazel configurations for running tests under sanitizers.
# Based on https://github.com/bazelment/trunk/blob/master/tools/bazel.rc

# Enable automatic configs based on platform
common --enable_platform_specific_config

# Needed by gRPC to build on some platforms.
build --copt -DGRPC_BAZEL_BUILD

# Set minimum supported C++ version
build --host_cxxopt=-std=c++14 --cxxopt=-std=c++14
build:macos --host_cxxopt=-std=c++14 --cxxopt=-std=c++14
build:linux --host_cxxopt=-std=c++14 --cxxopt=-std=c++14
build:windows --host_cxxopt=/std:c++14 --cxxopt=/std:c++14

# --config=asan : Address Sanitizer.
common:asan --copt -DADDRESS_SANITIZER
Expand Down

1 comment on commit 8605fe8

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp api Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 8605fe8 Previous: 3f8d954 Ratio
BM_ProcYieldSpinLockThrashing/2/process_time/real_time 1.6675855339795747 ms/iter 0.20316458239997784 ms/iter 8.21
BM_ProcYieldSpinLockThrashing/4/process_time/real_time 3.3463303635760053 ms/iter 0.7371018816541125 ms/iter 4.54

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.