[CI] Benchmark workflow fails, C++14 required to build grpc (#2278)

open-telemetry · Aug 25, 2023 · 7196ec3 · 7196ec3 · github-actions · Aug 25, 2023
1 parent 628838a
commit 7196ec3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml
@@ -25,12 +25,12 @@ jobs:
           key: bazel_benchmark
       - name: setup
         run: |
-          sudo -E ./ci/setup_cmake.sh
-          sudo -E ./ci/setup_ci_environment.sh
+          sudo ./ci/setup_ci_environment.sh
+          sudo ./ci/install_bazelisk.sh
       - name: Run benchmark
         id: run_benchmarks
         run: |
-          CC=/usr/bin/gcc-10 CXX=/usr/bin/g++-10 ci/do_ci.sh bazel.benchmark
+          ./ci/do_ci.sh bazel.benchmark
           mkdir -p benchmarks
           mv api-benchmark_result.json benchmarks
           mv sdk-benchmark_result.json benchmarks

diff --git a/ci/do_ci.sh b/ci/do_ci.sh
@@ -25,7 +25,7 @@ function run_benchmarks
 
   [ -z "${BENCHMARK_DIR}" ] && export BENCHMARK_DIR=$HOME/benchmark
   mkdir -p $BENCHMARK_DIR
-  bazel $BAZEL_STARTUP_OPTIONS build --cxxopt=-std=c++14 $BAZEL_OPTIONS_ASYNC -c opt -- \
+  bazel $BAZEL_STARTUP_OPTIONS build --host_cxxopt=-std=c++14 --cxxopt=-std=c++14 $BAZEL_OPTIONS_ASYNC -c opt -- \
     $(bazel query 'attr("tags", "benchmark_result", ...)')
   echo ""
   echo "Benchmark results in $BENCHMARK_DIR:"
Benchmark suite	Current: `7196ec3`	Previous: `94a6783`	Ratio
`BM_SpinLockThrashing/1/process_time/real_time`	`1.014726161956787` ms/iter	`0.12369108372840329` ms/iter	`8.20`
`BM_NaiveSpinLockThrashing/1/process_time/real_time`	`1.0961082246568468` ms/iter	`0.13989227885877956` ms/iter	`7.84`
`BM_ThreadYieldSpinLockThrashing/1/process_time/real_time`	`20.10480562845866` ms/iter	`7.126951217651367` ms/iter	`2.82`
`BM_ThreadYieldSpinLockThrashing/2/process_time/real_time`	`52.430947621663414` ms/iter	`15.15621609157986` ms/iter	`3.46`