Skip to content

Commit

Permalink
[Deprecation] Deprecate experimental semantic conventions (#1742) (#1744
Browse files Browse the repository at this point in the history
)

Fixes #1742
  • Loading branch information
marcalff authored Nov 9, 2022
1 parent a220ac4 commit 702a68c
Showing 1 changed file with 25 additions and 0 deletions.
25 changes: 25 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,31 @@ Increment the:
[#1733](https://github.com/open-telemetry/opentelemetry-cpp/pull/1733)
* [BUILD] Add CMake OTELCPP_PROTO_PATH [#1730](https://github.com/open-telemetry/opentelemetry-cpp/pull/1730)

Deprecation notes:

* [Deprecation] Deprecate experimental semantic conventions
[#1744](https://github.com/open-telemetry/opentelemetry-cpp/pull/1744)
* The file
`api/include/opentelemetry/trace/experimental_semantic_conventions.h`
is deprecated, and will be removed in a future release.
Use file
`api/include/opentelemetry/trace/semantic_conventions.h`
instead.

* The file
`sdk/include/opentelemetry/sdk/resource/experimental_semantic_conventions.h`
is deprecated, and will be removed in a future release.
Use file
`sdk/include/opentelemetry/sdk/resource/semantic_conventions.h`
instead.

* The function, declared in the global namespace
`uint32_t hashCode(const char *str, uint32_t h = 0)`
is deprecated, and will be removed in a future release.
No replacement will be provided.
Note that function `opentelemetry::utils::hashCode`,
declared in the ETW exporter, is not affected by this deprecation.

## [1.7.0] 2022-10-28

* [METRICS SDK] Validate Instrument meta data (name, unit, description) [#1713](https://github.com/open-telemetry/opentelemetry-cpp/pull/1713)
Expand Down

2 comments on commit 702a68c

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp api Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 702a68c Previous: a220ac4 Ratio
BM_ThreadYieldSpinLockThrashing/1/process_time/real_time 6.756078629266648 ms/iter 2.0872535127581973 ms/iter 3.24
BM_ThreadYieldSpinLockThrashing/2/process_time/real_time 27.700066566467285 ms/iter 11.72576347986857 ms/iter 2.36

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp sdk Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 702a68c Previous: a220ac4 Ratio
BM_AttributseProcessorFilter 260.80278494509014 ns/iter 115.25207367009264 ns/iter 2.26
BM_BaselineBuffer/2 11291801.929473877 ns/iter 2640237.0929718018 ns/iter 4.28
BM_LockFreeBuffer/1 8747353.553771973 ns/iter 219359.9256589787 ns/iter 39.88

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.