Skip to content

Commit

Permalink
Fix ObservableInstrument::RemoveCallback (#1582)
Browse files Browse the repository at this point in the history
  • Loading branch information
ahadnagy authored Aug 26, 2022
1 parent cecfc19 commit 1f37839
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sdk/src/metrics/async_instruments.cc
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ void ObservableInstrument::AddCallback(opentelemetry::metrics::ObservableCallbac
void ObservableInstrument::RemoveCallback(opentelemetry::metrics::ObservableCallbackPtr callback,
void *state) noexcept
{
observable_registry_->AddCallback(callback, state, this);
observable_registry_->RemoveCallback(callback, state, this);
}

const InstrumentDescriptor &ObservableInstrument::GetInstrumentDescriptor()
Expand Down

1 comment on commit 1f37839

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp sdk Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 1f37839 Previous: cecfc19 Ratio
BM_LockFreeBuffer/2 2838848.7463966412 ns/iter 951813.2209777832 ns/iter 2.98

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.