[EXPORTER] Fix crash in ElasticsearchLogRecordExporter when (#3082)

using constructor with user given options (#3078) Closes #3078
open-telemetry · Oct 8, 2024 · 0ea1f2c · 0ea1f2c
1 parent fa0a520
commit 0ea1f2c
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/exporters/elasticsearch/src/es_log_record_exporter.cc b/exporters/elasticsearch/src/es_log_record_exporter.cc
@@ -288,7 +288,12 @@ class AsyncResponseHandler : public http_client::EventHandler
 #endif
 
 ElasticsearchLogRecordExporter::ElasticsearchLogRecordExporter()
-    : options_{ElasticsearchExporterOptions()},
+    : ElasticsearchLogRecordExporter(ElasticsearchExporterOptions())
+{}
+
+ElasticsearchLogRecordExporter::ElasticsearchLogRecordExporter(
+    const ElasticsearchExporterOptions &options)
+    : options_{options},
       http_client_{ext::http::client::HttpClientFactory::Create()}
 #ifdef ENABLE_ASYNC_EXPORT
       ,
@@ -301,11 +306,6 @@ ElasticsearchLogRecordExporter::ElasticsearchLogRecordExporter()
 #endif
 }
 
-ElasticsearchLogRecordExporter::ElasticsearchLogRecordExporter(
-    const ElasticsearchExporterOptions &options)
-    : options_{options}, http_client_{ext::http::client::HttpClientFactory::Create()}
-{}
-
 std::unique_ptr<sdklogs::Recordable> ElasticsearchLogRecordExporter::MakeRecordable() noexcept
 {
   return std::unique_ptr<sdklogs::Recordable>(new ElasticSearchRecordable());