Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go.opentelemetry.io/proto/otlp to v1.2.0 #9985

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

dashpole
Copy link
Contributor

Description:

Update the OTLP proto dependency and generated code. I plan to use the metric.metadata field to support additional prometheus types per https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/prometheus_and_openmetrics.md#metric-metadata

@dashpole dashpole requested review from a team and songy23 April 17, 2024 16:38
@dashpole
Copy link
Contributor Author

(this probably doesn't need a changelog entry)

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.70%. Comparing base (29240d9) to head (57762ef).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9985   +/-   ##
=======================================
  Coverage   91.70%   91.70%           
=======================================
  Files         358      358           
  Lines       16543    16543           
=======================================
  Hits        15171    15171           
  Misses       1045     1045           
  Partials      327      327           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songy23 songy23 added dependencies Pull requests that update a dependency file Skip Changelog PRs that do not require a CHANGELOG.md entry labels Apr 17, 2024
@codeboten codeboten added Skip Changelog PRs that do not require a CHANGELOG.md entry and removed Skip Changelog PRs that do not require a CHANGELOG.md entry labels Apr 18, 2024
@codeboten codeboten merged commit fcdfdaa into open-telemetry:main Apr 18, 2024
84 of 101 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 18, 2024
@dashpole dashpole deleted the bump_proto branch April 19, 2024 18:10
codeboten pushed a commit that referenced this pull request Apr 19, 2024
#### Description

After
#9985, add
support for the new metric.metadata field in the pmetric package.

I plan to use the metric.metadata field to support additional prometheus
types per
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/prometheus_and_openmetrics.md#metric-metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants