Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd/mdatagen] [chore] Small fixes for new resource attributes filter #9950

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

dmitryax
Copy link
Member

  • Make sure we always pass a string to the filter.Match even if the attribute value has a different type. Otherwise, it panics.
  • Make sure we show the if_configured warning if the user sets include/exclude without enabled.
  • Simplify generated tests

Follow up to #9660

@dmitryax dmitryax requested review from a team and codeboten April 12, 2024 07:53
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 91.80%. Comparing base (878bba2) to head (335973e).

Files Patch % Lines
...plereceiver/internal/metadata/generated_metrics.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9950      +/-   ##
==========================================
+ Coverage   91.75%   91.80%   +0.04%     
==========================================
  Files         358      358              
  Lines       16569    16568       -1     
==========================================
+ Hits        15203    15210       +7     
+ Misses       1038     1034       -4     
+ Partials      328      324       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax
Copy link
Member Author

The coverage hasn't changed. I just touched a part that is not covered and probably don't need to be

- Make sure we always pass string to the filter.Match even if attribute value is different type. Otherwise it panics.
- Make sure we show the if_configured warning if user sets include/exclude
- Simplify generated tests
@dmitryax dmitryax merged commit b1e075f into open-telemetry:main Apr 12, 2024
47 of 48 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 12, 2024
@dmitryax dmitryax deleted the simplify-filter-mdatagen branch April 12, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants