[chore] Updated unmarshalText func
#9838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…marshalText-in-`configcompression`
…marshalText-in-`configcompression`
…marshalText-in-`configcompression`
…of-switch-on-UnmarshalText-in-`configcompression`
|
hey @TylerHelmuth, I renamed the branch Hello @dmitryax can I please get a review |
TylerHelmuth
approved these changes
Mar 25, 2024
dmitryax
reviewed
Mar 26, 2024
dmitryax
changed the title
unmarshalText funcunmarshalText func
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9838 +/- ##
=======================================
Coverage 91.32% 91.32%
=======================================
Files 356 356
Lines 19163 19169 +6
=======================================
+ Hits 17500 17506 +6
Misses 1335 1335
Partials 328 328 ☔ View full report in Codecov by Sentry. |
codeboten
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the switch statement in
UnmarshalTextfunction to an if statement {configcompression}Link to the issue: #9458