Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client] Remove experimental comment from Metadata #9796

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

TylerHelmuth
Copy link
Member

Description:
Removes the experimental tag from Metadata. This feature has been used in the headerssetter extension since Aug 2022.

Link to tracking Issue:
Relates to #9381
Related to #9795

@TylerHelmuth TylerHelmuth added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 19, 2024
@TylerHelmuth TylerHelmuth requested review from mx-psi and a team March 19, 2024 20:17
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.13%. Comparing base (a327d55) to head (42a501c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9796      +/-   ##
==========================================
- Coverage   91.15%   91.13%   -0.02%     
==========================================
  Files         353      353              
  Lines       18746    18746              
==========================================
- Hits        17088    17085       -3     
- Misses       1331     1333       +2     
- Partials      327      328       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on #9818, everything on here should be taken as 'experimental', so I am fine removing this

@mx-psi mx-psi merged commit f237238 into open-telemetry:main Mar 27, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 27, 2024
@TylerHelmuth TylerHelmuth deleted the client-remove-experimental branch March 27, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants