[chore] change the way we unmarshal the config in tests #9765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9765 +/- ##
=======================================
Coverage 90.97% 90.97%
=======================================
Files 353 353
Lines 18616 18616
=======================================
Hits 16936 16936
Misses 1354 1354
Partials 326 326 ☔ View full report in Codecov by Sentry. |
dmitryax
approved these changes
Mar 14, 2024
dmitryax
pushed a commit
that referenced
this pull request
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is required in preparation of #9750
This removes the call to
component.UnmarshalConfigin preparation of its deprecation, and instead has theConfobject unmarshal itself into theConfigstruct.