[exporterhelper] Turn panics into errors #9717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
force-pushed
the
mx-psi/fallible-options-exporterhelper
branch
from
37523ee
to
89b9e4f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9717 +/- ##
=======================================
Coverage 90.90% 90.90%
=======================================
Files 348 348
Lines 18384 18388 +4
=======================================
+ Hits 16712 16716 +4
Misses 1348 1348
Partials 324 324 ☔ View full report in Codecov by Sentry. |
mx-psi
changed the title
dmitryax
reviewed
Mar 6, 2024
mx-psi
force-pushed
the
mx-psi/fallible-options-exporterhelper
branch
from
cca1117
to
e099e9d
Compare
dmitryax
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Turns panics into errors