Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a workflow to test otelcorecol as a Windows service #9689

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

pjanotti
Copy link
Contributor

@pjanotti pjanotti commented Mar 4, 2024

Description:
Adding a workflow to fix #6455 this will also be needed when fixing #5300

Fixes #6455

Link to tracking Issue:
#6455

@pjanotti pjanotti requested review from a team and djaglowski March 4, 2024 22:37
Comment on lines +42 to +57
- name: Checkout Repo
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- name: Setup Go
uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
with:
go-version: ~1.21.5
cache: false
- name: Cache Go
uses: actions/cache@13aacd865c20de90d75de3b17ebe84f7a17d57d2 # v4.0.0
env:
cache-name: cache-go-modules
with:
path: |
~\go\pkg\mod
~\AppData\Local\go-build
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems repeated in various jobs it seems possible to put all these common steps in a shared action. I will take a look that later.

Comment on lines +67 to +70
- name: Test otelcorecol service
run: |
(Start-Service otelcorecol -PassThru).WaitForStatus('Running', '00:00:30')
(Stop-Service otelcorecol -PassThru).WaitForStatus('Stopped', '00:00:30')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When implementing #5300 I will switch this to a golang test.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.90%. Comparing base (1059d5b) to head (4fdae4e).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9689   +/-   ##
=======================================
  Coverage   90.90%   90.90%           
=======================================
  Files         348      348           
  Lines       18382    18382           
=======================================
  Hits        16710    16710           
  Misses       1348     1348           
  Partials      324      324           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 6, 2024
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Paulo!

@dmitryax dmitryax merged commit 2d98df2 into open-telemetry:main Mar 6, 2024
63 of 64 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 6, 2024
codeboten pushed a commit that referenced this pull request Aug 1, 2024
I'm volunteering myself to own the tier 2 support for windows/amd64.
This will put the windows/amd64 on par with the other tier 2 platforms
by having a specific person owning it.

Some of Windows related things that I contribute(d):

* Codeowner of various Windows related components in contrib
(pkg/winperfcounters, activedirectorydsreceiver, iisreceiver,
windowseventlogreceiver, and windowsperfcountersreceiver)
* Fixing Windows related issues (e.g.: #9042, #9689, #9726,
open-telemetry/opentelemetry-collector-contrib#30743)
* MSI on the collector releases repo
(open-telemetry/opentelemetry-collector-releases#560)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test to validate service is up and running on windows
2 participants