Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confignet] Remove deprecated functions #9363

Conversation

TylerHelmuth
Copy link
Member

Description:
Remove deprecated functions from confignet.

Link to tracking Issue:
Closes #9105

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f13e6a3) 90.19% compared to head (25f65d4) 90.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9363      +/-   ##
==========================================
+ Coverage   90.19%   90.24%   +0.05%     
==========================================
  Files         345      345              
  Lines       18025    18017       -8     
==========================================
+ Hits        16257    16260       +3     
+ Misses       1439     1429      -10     
+ Partials      329      328       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi
Copy link
Member

mx-psi commented Jan 24, 2024

Can you fix the merge conflict?

@TylerHelmuth TylerHelmuth force-pushed the confignet-remove-deprecated-functions branch from a7e85a6 to 25f65d4 Compare January 24, 2024 19:16
@TylerHelmuth TylerHelmuth marked this pull request as ready for review January 24, 2024 19:16
@TylerHelmuth TylerHelmuth requested review from a team and Aneurysm9 January 24, 2024 19:16
TylerHelmuth added a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Jan 24, 2024
@TylerHelmuth TylerHelmuth added the ready-to-merge Code review completed; ready to merge by maintainers label Jan 24, 2024
@dmitryax dmitryax merged commit 6b3b181 into open-telemetry:main Jan 25, 2024
35 of 38 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 25, 2024
@TylerHelmuth TylerHelmuth deleted the confignet-remove-deprecated-functions branch January 25, 2024 05:51
mx-psi pushed a commit to mx-psi/opentelemetry-collector that referenced this pull request Jan 25, 2024
**Description:** 
Remove deprecated functions from confignet.

**Link to tracking Issue:** Closes open-telemetry#9105
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[confignet] Update public methods to accept context.Context
6 participants