-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[confignet] Remove deprecated functions #9363
Merged
dmitryax
merged 1 commit into
open-telemetry:main
from
TylerHelmuth:confignet-remove-deprecated-functions
Jan 25, 2024
Merged
[confignet] Remove deprecated functions #9363
dmitryax
merged 1 commit into
open-telemetry:main
from
TylerHelmuth:confignet-remove-deprecated-functions
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9363 +/- ##
==========================================
+ Coverage 90.19% 90.24% +0.05%
==========================================
Files 345 345
Lines 18025 18017 -8
==========================================
+ Hits 16257 16260 +3
+ Misses 1439 1429 -10
+ Partials 329 328 -1 ☔ View full report in Codecov by Sentry. |
bogdandrutu
approved these changes
Jan 24, 2024
mx-psi
approved these changes
Jan 24, 2024
Can you fix the merge conflict? |
evan-bradley
approved these changes
Jan 24, 2024
codeboten
approved these changes
Jan 24, 2024
TylerHelmuth
force-pushed
the
confignet-remove-deprecated-functions
branch
from
January 24, 2024 19:16
a7e85a6
to
25f65d4
Compare
TylerHelmuth
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Jan 24, 2024
TylerHelmuth
added
the
ready-to-merge
Code review completed; ready to merge by maintainers
label
Jan 24, 2024
dmitryax
approved these changes
Jan 25, 2024
mx-psi
pushed a commit
to mx-psi/opentelemetry-collector
that referenced
this pull request
Jan 25, 2024
**Description:** Remove deprecated functions from confignet. **Link to tracking Issue:** Closes open-telemetry#9105
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove deprecated functions from confignet.
Link to tracking Issue:
Closes #9105