Remove the obsolete +build directive #9304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"// +build" was replaced with "//go:build" directive in 1.17. +build can be removed since we support only 1.20 and 1.21
dmitryax
force-pushed
the
remove-old-go-build
branch
from
4ab7a2c
to
e689d51
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9304 +/- ##
=======================================
Coverage 90.33% 90.33%
=======================================
Files 340 340
Lines 17968 17968
=======================================
Hits 16232 16232
Misses 1412 1412
Partials 324 324 ☔ View full report in Codecov by Sentry. |
codeboten
approved these changes
Jan 17, 2024
bogdandrutu
approved these changes
Jan 17, 2024
This was referenced Jan 17, 2024
dmitryax
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Jan 17, 2024
To pick up open-telemetry/opentelemetry-collector#9304 and remove obsolete directives from files generated by the builder. --------- Signed-off-by: Dmitrii Anoshin <anoshindx@gmail.com>
dmitryax
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Jan 17, 2024
`// +build` was replaced with `//go:build` directive in Go 1.17. +build can be removed since we support only 1.20 and 1.21 Same as open-telemetry/opentelemetry-collector#9304
mfyuce
pushed a commit
to mfyuce/opentelemetry-collector-contrib
that referenced
this pull request
Jan 18, 2024
To pick up open-telemetry/opentelemetry-collector#9304 and remove obsolete directives from files generated by the builder. --------- Signed-off-by: Dmitrii Anoshin <anoshindx@gmail.com>
mfyuce
pushed a commit
to mfyuce/opentelemetry-collector-contrib
that referenced
this pull request
Jan 18, 2024
`// +build` was replaced with `//go:build` directive in Go 1.17. +build can be removed since we support only 1.20 and 1.21 Same as open-telemetry/opentelemetry-collector#9304
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
To pick up open-telemetry/opentelemetry-collector#9304 and remove obsolete directives from files generated by the builder. --------- Signed-off-by: Dmitrii Anoshin <anoshindx@gmail.com>
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
`// +build` was replaced with `//go:build` directive in Go 1.17. +build can be removed since we support only 1.20 and 1.21 Same as open-telemetry/opentelemetry-collector#9304
lapis-lark
pushed a commit
to lapis-lark/otel-cassandra-exporter-rework
that referenced
this pull request
Nov 4, 2024
To pick up open-telemetry/opentelemetry-collector#9304 and remove obsolete directives from files generated by the builder. --------- Signed-off-by: Dmitrii Anoshin <anoshindx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
// +buildwas replaced with//go:builddirective in Go 1.17. The+buildcan be removed since we support only 1.20 and 1.21