[configtls] add include_system_ca_certs_pool #9142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9142 +/- ##
==========================================
+ Coverage 90.34% 90.37% +0.02%
==========================================
Files 340 340
Lines 17989 17996 +7
==========================================
+ Hits 16253 16263 +10
+ Misses 1412 1410 -2
+ Partials 324 323 -1 ☔ View full report in Codecov by Sentry. |
atoulme
changed the title
codeboten
reviewed
Dec 20, 2023
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
dmitryax
reviewed
Jan 8, 2024
…pool is not initialized properly by the system
atoulme
force-pushed
the
UseSystemCACerts
branch
from
472de3f to
073f6b1
Compare
Contributor
Author
|
Rebased, anything else to do here? |
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
dmitryax
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add
include_system_ca_certs_poolto configtls, allowing to load system certs and additional custom certs.Link to tracking Issue:
Fixes #7774
Testing:
UTs
Documentation:
Added to README