Add dmitryax as an approver #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dmitrii has been actively working on the Collector and has already contributed 23 commits, most of them quite substantial. I vouch for him.
tigrannajaryan
requested review from
bogdandrutu,
flands,
owais,
pjanotti,
rghetia and
songy23
as code owners
bogdandrutu
approved these changes
Apr 30, 2020
Codecov Report
@@ Coverage Diff @@
## master #895 +/- ##
==========================================
+ Coverage 85.94% 85.96% +0.01%
==========================================
Files 172 172
Lines 13136 13136
==========================================
+ Hits 11290 11292 +2
+ Misses 1419 1417 -2
Partials 427 427
Continue to review full report at Codecov.
|
|
Please leave this PR for 1 day at least open. |
pjanotti
approved these changes
Apr 30, 2020
rghetia
approved these changes
May 1, 2020
tigrannajaryan
pushed a commit
to tigrannajaryan/opentelemetry-collector-contrib
that referenced
this pull request
May 1, 2020
dmitryax is already an approver on the Collector core: open-telemetry/opentelemetry-collector#895 This ensures he has the approving permission in this repo too.
bogdandrutu
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
May 1, 2020
dmitryax is already an approver on the Collector core: open-telemetry/opentelemetry-collector#895 This ensures he has the approving permission in this repo too.
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
Dmitrii has been actively working on the Collector and has already contributed 23 commits, most of them quite substantial. I vouch for him.
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector-contrib
that referenced
this pull request
Jul 13, 2020
dmitryax is already an approver on the Collector core: open-telemetry/opentelemetry-collector#895 This ensures he has the approving permission in this repo too.
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dmitrii has been actively working on the Collector and has
already contributed 23 commits, most of them quite substantial.
I vouch for him.