[exporterhelper] make enqueue failures available #8674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
pushed a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
Oct 12, 2023
When looking at open-telemetry#8674, I ran into some changes that were harder than they needed to in the test utility. I'm separating changes to the prometheusChecker into a separate PR to reduce the size of 8674. Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
pushed a commit
that referenced
this pull request
Oct 12, 2023
When looking at #8674, I ran into some changes that were harder than they needed to in the test utility. I'm separating changes to the prometheusChecker into a separate PR to reduce the size of 8674. Signed-off-by: Alex Boten <aboten@lightstep.com>
These metrics were only exporter either via OC or via the prometheus exporter. Fixes open-telemetry#8673 Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
force-pushed
the
codeboten/fix-8673
branch
from
59142cc
to
94e2f4c
Compare
Codecov ReportAttention:
... and 8 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
moh-osman3
reviewed
Oct 13, 2023
dmitryax
reviewed
Oct 17, 2023
Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
codeboten
commented
Oct 20, 2023
|
@jmacd @moh-osman3 @dmitryax could I get another review on this, would be great to get this out in the next release. |
dmitryax
approved these changes
Oct 20, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These metrics were only exporter either via OC or via the prometheus exporter. Fixes #8673