-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stability levels to components output #8289
Add stability levels to components output #8289
Conversation
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
e25788e
to
c8a82ad
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8289 +/- ##
==========================================
+ Coverage 90.18% 90.39% +0.21%
==========================================
Files 302 303 +1
Lines 15859 15946 +87
==========================================
+ Hits 14303 14415 +112
+ Misses 1261 1237 -24
+ Partials 295 294 -1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs changelog entry, otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Please add a changelog to capture the enhancement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if users would use this output to create their configs? If that is the case, would this break their flow?
I do understand that this is nice to have, but would like to document what is the components command for (it's purpose). If it is only for info only and debugging then let's document that the output is not intended to be stable and programmatically used.
They shouldn't.
Good idea, I added a long description to the command to make it clear. |
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
This is now ready for the next review. |
Fixes open-telemetry/opentelemetry-collector-contrib#9518
Example output:
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de